Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: ignore non-working legacy pgpass ......................................................................
Patch Set 2: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/legacy/database.py Line 85: otopicons.CoreEnv.LOG_FILTER Line 86: ].append( Line 87: dbenv[osetupcons.DBEnv.PASSWORD] Line 88: ) Line 89: try: As I said, it's the other way around. We used to do: If we have ca cert and do not have postinstall, it's legacy upgrade If it's legacy upgrade, process pgpass But the condition was too weak - in many cases we wrongly tried to do legacy upgrade. So, in e7b37ed550e6aa4ffb0010c01764fe5088ed66ef, we changed it to be the other way around - to have more mandatory conditions for deciding that we are doing a legacy upgrade. One of these conditions was having legacy pgpass credentials. So pgpass had to be checked before deciding if we are doing a legacy upgrade. So, to answer your last question, yes. We can give up on one of the conditions, partially revert e7b37ed550e6aa4ffb0010c01764fe5088ed66ef, and only look at pgpass during stage setup (say) if stage init decided we are doing a legacy upgrade. I'd rather not, mostly because I do not see any reason to do so. Do you? Line 90: dbovirtutils = database.OvirtUtils(plugin=self) Line 91: dbovirtutils.tryDatabaseConnect(dbenv) Line 92: self.environment.update(dbenv) Line 93: break -- To view, visit http://gerrit.ovirt.org/21186 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddad631ff679f3ba2e338c0925e046ff569b587e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
