Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: ignore non-working legacy pgpass ......................................................................
Patch Set 2: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/legacy/database.py Line 85: otopicons.CoreEnv.LOG_FILTER Line 86: ].append( Line 87: dbenv[osetupcons.DBEnv.PASSWORD] Line 88: ) Line 89: try: The exact specific scenario that made me work on this is detailed in the bug. Since e7b37ed550e6aa4ffb0010c01764fe5088ed66ef we remove pgpass on 3.3 setup, so it's less likely to occur, but still can - e.g. if someone installed 3.2, upgraded to 3.3.0, then ran cleanup and will try to install 3.3.2. Line 90: dbovirtutils = database.OvirtUtils(plugin=self) Line 91: dbovirtutils.tryDatabaseConnect(dbenv) Line 92: self.environment.update(dbenv) Line 93: break -- To view, visit http://gerrit.ovirt.org/21186 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddad631ff679f3ba2e338c0925e046ff569b587e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
