Yedidyah Bar David has posted comments on this change.

Change subject: packaging: setup: ignore non-working legacy pgpass
......................................................................


Patch Set 1:

(1 comment)

....................................................
File packaging/setup/plugins/ovirt-engine-setup/legacy/database.py
Line 93:                                 self.logger.debug(
Line 94:                                     'Cannot connect to database using '
Line 95:                                     'existing pgpass file, ignoring 
it',
Line 96:                                     exc_info=True,
Line 97:                                 )
Yes, but since some time ago, it's the other way around - this code is now in 
stage init, and the decision whether we are doing an upgrade from legacy is 
(also) based on the result of this function (and the LEGACY_PG_CREDS_FOUND 
value)
Line 98: 
Line 99:     @plugin.event(
Line 100:         stage=plugin.Stages.STAGE_SETUP,
Line 101:         before=(


-- 
To view, visit http://gerrit.ovirt.org/21186
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iddad631ff679f3ba2e338c0925e046ff569b587e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to