Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: ignore non-working legacy pgpass ......................................................................
Patch Set 1: (2 comments) .................................................... File packaging/setup/plugins/ovirt-engine-setup/legacy/database.py Line 81 Line 82 Line 83 Line 84 Line 85 Not sure what you mean - I do intend to hide the password in this case (even if it's not used), just had a copy/paste bug :-). Fixed. Line 93: self.logger.debug( Line 94: 'Cannot connect to database using ' Line 95: 'existing pgpass file, ignoring it', Line 96: exc_info=True, Line 97: ) I agree that's not good. Changed to always set LEGACY_PG_CREDS_FOUND if the file contains something that looks like credentials. Line 98: Line 99: @plugin.event( Line 100: stage=plugin.Stages.STAGE_SETUP, Line 101: before=( -- To view, visit http://gerrit.ovirt.org/21186 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddad631ff679f3ba2e338c0925e046ff569b587e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
