Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: ignore non-working legacy pgpass ......................................................................
Patch Set 2: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/legacy/database.py Line 85: otopicons.CoreEnv.LOG_FILTER Line 86: ].append( Line 87: dbenv[osetupcons.DBEnv.PASSWORD] Line 88: ) Line 89: try: so why is this change is required? what are we trying to solve? in current implementation we took the details of the first user and continue to the next stage which will fail if credentials are incorrect, which is invalid machine state anyway... as we are trying to upgrade from non workable environment. Line 90: dbovirtutils = database.OvirtUtils(plugin=self) Line 91: dbovirtutils.tryDatabaseConnect(dbenv) Line 92: self.environment.update(dbenv) Line 93: break -- To view, visit http://gerrit.ovirt.org/21186 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddad631ff679f3ba2e338c0925e046ff569b587e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
