Alon Bar-Lev has posted comments on this change. Change subject: engine: no documentation message ......................................................................
Patch Set 4: (2 comments) Please make it work with upstream manual... we should have at least one page manual with some nice message that manual is not installed, and the no_lang servlet should produce valid output for upstream. I suggest to refer it to root URI using redirect so you can use branding as usual to customize its look and feel. .................................................... File backend/manager/modules/root/src/main/webapp/WEB-INF/help/no_lang.jsp Line 4 Line 5 Line 6 Line 7 Line 8 We do... see packaging/manual All should work well at upstream. Line 11 Line 12 Line 13 Line 14 Line 15 this should be gotten out of branding. -- To view, visit http://gerrit.ovirt.org/19848 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iceae0ebf671efc951522c464db1a5b2b95dd5637 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
