Alexander Wels has posted comments on this change. Change subject: engine: no documentation message ......................................................................
Patch Set 4: (5 comments) It should be straight forward to remove the messages from 404. But that should be a different patch. .................................................... File backend/manager/modules/root/src/main/webapp/WEB-INF/help/no_lang.jsp Line 4 Line 5 Line 6 Line 7 Line 8 correct, not unless we have some documentation package. Line 9 Line 10 Line 11 Line 12 Line 13 correct, not unless we have some documentation package. Line 11 Line 12 Line 13 Line 14 Line 15 Probably not, we should probably redesign this page a little bit and remove any downstream references like this. Line 12 Line 13 Line 14 Line 15 Line 16 correct, not unless we have some documentation package. Actually, I am thinking about removing the DocsServlet altogether and go back to using the FileServlet (which is a super class of the DocsServlet). And get the logic that is in the DocsServlet right now into a filter, which is more appropriate I think. Line 1: <%@ page language="java" contentType="text/html; charset=UTF-8" pageEncoding="UTF-8" session="false" %> Line 2: <%@ taglib uri="http://java.sun.com/jsp/jstl/core"; prefix="c" %> Line 3: <%@ taglib uri="http://java.sun.com/jsp/jstl/fmt"; prefix="fmt" %> Line 4: <fmt:setBundle basename="org.ovirt.engine.core.docswarning" /> -- To view, visit http://gerrit.ovirt.org/19848 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iceae0ebf671efc951522c464db1a5b2b95dd5637 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
