Alexander Wels has posted comments on this change. Change subject: engine: no documentation message ......................................................................
Patch Set 6: (7 comments) .................................................... File backend/manager/modules/root/src/main/java/org/ovirt/engine/core/DocsMissingServlet.java You are right its gone. Line 1: package org.ovirt.engine.core; Line 2: Line 3: import java.io.IOException; Line 4: .................................................... File backend/manager/modules/root/src/main/webapp/WEB-INF/help/no_lang.jsp Line 1: <%@ page pageEncoding="UTF-8" session="false" %> Line 2: <%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core"; %> Line 3: <%@ taglib prefix="fmt" uri="http://java.sun.com/jsp/jstl/fmt"; %> Line 4: <fmt:setBundle basename="org.ovirt.engine.core.docswarning" var="docs"/> Well I don't wish to debate whether it is better to have one massive messages bundle or a bunch of seperate bundles. It seems it is standard here to have one massive one. So I will comply with the standard here, but that doesn't mean I agree with this particular practice. Line 5: <!DOCTYPE html> Line 6: <html> Line 7: <head> Line 8: <meta http-equiv="Content-type" content="text/html; charset=utf-8" /> Line 5: <!DOCTYPE html> Line 6: <html> Line 7: <head> Line 8: <meta http-equiv="Content-type" content="text/html; charset=utf-8" /> Line 9: <link rel="shortcut icon" href="${pageContext.request.contextPath}/ovirt-engine-theme-resource/favicon" type="image/x-icon" /> Done Line 10: <title><fmt:message key="docs.missing.title" bundle="${docs}"> Line 11: <fmt:param value="${requestScope['locale'].getDisplayLanguage()}" /> Line 12: </fmt:message> Line 13: </title> Line 13: </title> Line 14: <c:if test="${requestScope['brandingStyle'] != null}"> Line 15: <c:forEach items="${requestScope['brandingStyle']}" var="theme"> Line 16: <c:if test="${theme.getThemeStyleSheet(requestScope['applicationType']) != null}"> Line 17: <link rel="stylesheet" type="text/css" href="${pageContext.request.contextPath}/ovirt-engine-theme${theme.path}/${theme.getThemeStyleSheet(requestScope['applicationType'])}"> Done Line 18: </c:if> Line 19: </c:forEach> Line 20: </c:if> Line 21: </head> Line 16: <c:if test="${theme.getThemeStyleSheet(requestScope['applicationType']) != null}"> Line 17: <link rel="stylesheet" type="text/css" href="${pageContext.request.contextPath}/ovirt-engine-theme${theme.path}/${theme.getThemeStyleSheet(requestScope['applicationType'])}"> Line 18: </c:if> Line 19: </c:forEach> Line 20: </c:if> Done Line 21: </head> Line 22: <body> Line 23: <div> Line 24: <div class="obrand_left"> .................................................... File backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml Line 65: <param-name>file</param-name> Line 66: <param-value>%{ENGINE_MANUAL}</param-value> Line 67: </init-param> Line 68: <init-param> Line 69: <param-name>forwardPath</param-name> Huh, not sure what you mean. Line 70: <param-value>/ovirt-engine/docsmissing</param-value> Line 71: </init-param> Line 72: </servlet> Line 73: <servlet-mapping> Line 200: Line 201: <filter-mapping> Line 202: <filter-name>BrandingFilter</filter-name> Line 203: <url-pattern>/ovirt-engine</url-pattern> Line 204: <url-pattern>/ovirt-engine/docsmissing</url-pattern> This is the pattern to apply the branding filter to. unless we want to blanket apply it to everything under /ovirt-engine. Line 205: <dispatcher>FORWARD</dispatcher> Line 206: <dispatcher>REQUEST</dispatcher> Line 207: </filter-mapping> Line 208: -- To view, visit http://gerrit.ovirt.org/19848 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iceae0ebf671efc951522c464db1a5b2b95dd5637 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
