Alon Bar-Lev has posted comments on this change. Change subject: engine: no documentation message ......................................................................
Patch Set 4: (5 comments) .................................................... File backend/manager/modules/root/src/main/webapp/WEB-INF/help/no_lang.jsp Line 4 Line 5 Line 6 Line 7 Line 8 we do not have this, right? Line 9 Line 10 Line 11 Line 12 Line 13 we do not have this, right? Line 11 Line 12 Line 13 Line 14 Line 15 is this appropriate? Line 12 Line 13 Line 14 Line 15 Line 16 we do not have this, right? using this page as hard coded within the DocsServlet will not enable us to reuse the DocsServlet to other static content. I suggest to have init parameter to DocsServlet which specify which jsp to run. I prefer to perform redirect as we discussed... but still, think how we can reuse. Line 1: <%@ page language="java" contentType="text/html; charset=UTF-8" pageEncoding="UTF-8" session="false" %> Line 2: <%@ taglib uri="http://java.sun.com/jsp/jstl/core"; prefix="c" %> Line 3: <%@ taglib uri="http://java.sun.com/jsp/jstl/fmt"; prefix="fmt" %> Line 4: <fmt:setBundle basename="org.ovirt.engine.core.docswarning" /> -- To view, visit http://gerrit.ovirt.org/19848 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iceae0ebf671efc951522c464db1a5b2b95dd5637 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
