Alon Bar-Lev has posted comments on this change.
Change subject: engine: no documentation message
......................................................................
Patch Set 1:
(2 comments)
....................................................
File backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml
Line 188:
Line 189: <filter-mapping>
Line 190: <filter-name>BrandingFilter</filter-name>
Line 191: <url-pattern>/ovirt-engine</url-pattern>
Line 192: <url-pattern>/docs/*</url-pattern>
this is not branding... it should be in own servlet.
Line 193: <dispatcher>REQUEST</dispatcher>
Line 194: </filter-mapping>
Line 195:
Line 196: <filter-mapping>
....................................................
File packaging/branding/ovirt.brand/messages.properties
Line 66: obrand.docs.missing.appears=It appears that you do not have the {0}
documentation installed.
Line 67: obrand.docs.missing.admin=Please have your administrator install the
proper documentation.
Line 68: obrand.docs.missing.click_here=Please click here for the English
documentation.
Line 69: obrand.docs.missing.appear_once=This message will only be displayed
once per session.
Line 70: obrand.docs.missing.title=Missing language: {0}
branding is not string table, if you need string table better to have other
mechanism.
branding is what you want to customize upon marketing need (look&feel), or
customer need (again, look&feel).
--
To view, visit http://gerrit.ovirt.org/19848
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iceae0ebf671efc951522c464db1a5b2b95dd5637
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
