Juan Hernandez has posted comments on this change.
Change subject: packaging: Add support for absolute app path
......................................................................
Patch Set 2:
(1 comment)
....................................................
File packaging/conf/engine.conf.defaults.in
Line 111: ENGINE_APPS="@ENGINE_BEANS@"
Line 112: ENGINE_APPS="${ENGINE_APPS} @ENGINE_ROOT@"
Line 113: ENGINE_APPS="${ENGINE_APPS} @ENGINE_RESTAPI@"
Line 114: ENGINE_APPS="${ENGINE_APPS} @ENGINE_USERPORTAL@"
Line 115: ENGINE_APPS="${ENGINE_APPS} @ENGINE_WEBADMIN@"
I really don't understand what you want to do. Apparently you want to make a
different change reusing the commit message of this one, but doing a different
thing. As I said, if you don't like this change just don't use it, do your own,
will be much easier to review and merge.
The .jar files aren't web applications, they are EJB applications. Putting one
of these .jar files in a "webapp" directory is conceptually wrong.
Line 116:
Line 117: #
Line 118: # Flags to enable or disable the web server (the proxy) and the
Line 119: # connectors of the application server:
--
To view, visit http://gerrit.ovirt.org/13796
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30abd8c33bf4e879372dc3cf43b55f24ccdcfd6d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
