Juan Hernandez has posted comments on this change.
Change subject: packaging: Add support for absolute app path
......................................................................
Patch Set 2:
(2 comments)
....................................................
File packaging/conf/engine.conf.defaults.in
Line 107: # started by the engine. This is a list of space separated files or
Line 108: # directories that should be either absolute or relative to the value
of
Line 109: # the ENGINE_USR parameter:
Line 110: #
Line 111: ENGINE_APPS="@ENGINE_BEANS@"
Well behaved products shouldn't have cryptic syntax in configuration files.
Line 112: ENGINE_APPS="${ENGINE_APPS} @ENGINE_ROOT@"
Line 113: ENGINE_APPS="${ENGINE_APPS} @ENGINE_RESTAPI@"
Line 114: ENGINE_APPS="${ENGINE_APPS} @ENGINE_USERPORTAL@"
Line 115: ENGINE_APPS="${ENGINE_APPS} @ENGINE_WEBADMIN@"
Line 111: ENGINE_APPS="@ENGINE_BEANS@"
Line 112: ENGINE_APPS="${ENGINE_APPS} @ENGINE_ROOT@"
Line 113: ENGINE_APPS="${ENGINE_APPS} @ENGINE_RESTAPI@"
Line 114: ENGINE_APPS="${ENGINE_APPS} @ENGINE_USERPORTAL@"
Line 115: ENGINE_APPS="${ENGINE_APPS} @ENGINE_WEBADMIN@"
The objective was to deploy the userportal application independent of the rest
of the engine in order to serve its static content with the web server. That
has been rejected, so this discussion is fruitless.
I don't understand why you insist in making a difference between .war files and
other types of applications. In the Java EE world .war files are web
applications and .jar files are EJB applications. All of them are
"applications" and all of them have the same treatment: they are deployed by
the application server. In JBoss this means that they are placed in the
"deployments" directory (well, that is just one option) and the application
server picks them, regardless of their type. In our case the startup script
links them in that deployments directory, regardless of their type.
The purpose of this change is clearly stated in the commit message. If you want
it push it. If you want something different, like the wars directory, then
submit your own change.
Line 116:
Line 117: #
Line 118: # Flags to enable or disable the web server (the proxy) and the
Line 119: # connectors of the application server:
--
To view, visit http://gerrit.ovirt.org/13796
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30abd8c33bf4e879372dc3cf43b55f24ccdcfd6d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
