Juan Hernandez has posted comments on this change.
Change subject: packaging: Add support for absolute app path
......................................................................
Patch Set 2:
(2 comments)
....................................................
File packaging/conf/engine.conf.defaults.in
Line 107: # started by the engine. This is a list of space separated files or
Line 108: # directories that should be either absolute or relative to the value
of
Line 109: # the ENGINE_USR parameter:
Line 110: #
Line 111: ENGINE_APPS="@ENGINE_BEANS@"
That doesn't justify using cryptic constructs in configuration files. I am
happy to accept a limitation like forbidden space (or whatever separator) in
the installation directory if that means that we don't have to use this cryptic
syntax in the configuration file.
Line 112: ENGINE_APPS="${ENGINE_APPS} @ENGINE_ROOT@"
Line 113: ENGINE_APPS="${ENGINE_APPS} @ENGINE_RESTAPI@"
Line 114: ENGINE_APPS="${ENGINE_APPS} @ENGINE_USERPORTAL@"
Line 115: ENGINE_APPS="${ENGINE_APPS} @ENGINE_WEBADMIN@"
Line 111: ENGINE_APPS="@ENGINE_BEANS@"
Line 112: ENGINE_APPS="${ENGINE_APPS} @ENGINE_ROOT@"
Line 113: ENGINE_APPS="${ENGINE_APPS} @ENGINE_RESTAPI@"
Line 114: ENGINE_APPS="${ENGINE_APPS} @ENGINE_USERPORTAL@"
Line 115: ENGINE_APPS="${ENGINE_APPS} @ENGINE_WEBADMIN@"
As you know the objective of this patch was to allow deployment of applications
to directories outside /usr/share/ovirt-engine, something like
/usr/share/ovirt-engine-userportal.war, with the objective of being able to
install them without the rest of the ovirt-engine stuff. In that context
introducing that additional "wars" directory is useless.
In addition wars can't be moved to a different place (wars directory or
whatever) without the rest of the changes intended to extract them from the ear
(unless you want to use more symlinks).
And finally I don't see any benefit on that additional wars category as
applications will then be spread over different directories: web application
.war files in /usr/share/ovirt-engine/wars and ejb application .jar files in
/usr/share/ovirt-engine. If you really feel the need to make a new directory
make one for all the applications, as all of them have the same treatment for
both the startup script and the application server.
Line 116:
Line 117: #
Line 118: # Flags to enable or disable the web server (the proxy) and the
Line 119: # connectors of the application server:
--
To view, visit http://gerrit.ovirt.org/13796
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30abd8c33bf4e879372dc3cf43b55f24ccdcfd6d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
