Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Add support for absolute app path
......................................................................
Patch Set 2:
(4 comments)
....................................................
File packaging/conf/engine.conf.defaults.in
Line 107: # started by the engine. This is a list of space separated files or
Line 108: # directories that should be either absolute or relative to the value
of
Line 109: # the ENGINE_USR parameter:
Line 110: #
Line 111: ENGINE_APPS="@ENGINE_BEANS@"
please use quotes for shlex to work and we able to process spaces.
ENGINE_APPS="\"xxx\" \"yyy\""
Line 112: ENGINE_APPS="${ENGINE_APPS} @ENGINE_ROOT@"
Line 113: ENGINE_APPS="${ENGINE_APPS} @ENGINE_RESTAPI@"
Line 114: ENGINE_APPS="${ENGINE_APPS} @ENGINE_USERPORTAL@"
Line 115: ENGINE_APPS="${ENGINE_APPS} @ENGINE_WEBADMIN@"
Line 111: ENGINE_APPS="@ENGINE_BEANS@"
Line 112: ENGINE_APPS="${ENGINE_APPS} @ENGINE_ROOT@"
Line 113: ENGINE_APPS="${ENGINE_APPS} @ENGINE_RESTAPI@"
Line 114: ENGINE_APPS="${ENGINE_APPS} @ENGINE_USERPORTAL@"
Line 115: ENGINE_APPS="${ENGINE_APPS} @ENGINE_WEBADMIN@"
I think we can manage here with @ENGINE_WARS@/xxx for our provided wars.
Line 116:
Line 117: #
Line 118: # Flags to enable or disable the web server (the proxy) and the
Line 119: # connectors of the application server:
....................................................
File packaging/services/ovirt-engine.py
Line 149: mustExist=False,
Line 150: )
Line 151:
Line 152: def _setupEngineApps(self):
Line 153: for app in self._config.get('ENGINE_APPS').split():
this should use shlex.split(self._config.get('ENGINE_APPS'))
Line 154: self._setupEngineApp(app)
Line 155:
Line 156: def _setupEngineApp(self, app):
Line 157: # If the given application is not an absolute path then
Line 157: # If the given application is not an absolute path then
Line 158: # try to locate it in the resources directory:
Line 159: if not os.path.isabs(app):
Line 160: app = os.path.join(
Line 161: self._config.get('ENGINE_USR'),
ENGINE_WARS?
Line 162: app,
Line 163: )
Line 164: if not os.path.exists(app):
Line 165: self._logger.warning(
--
To view, visit http://gerrit.ovirt.org/13796
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30abd8c33bf4e879372dc3cf43b55f24ccdcfd6d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
