Alon Bar-Lev has posted comments on this change. Change subject: packaging: Add support for absolute app path ......................................................................
Patch Set 2: (1 comment) .................................................... File packaging/conf/engine.conf.defaults.in Line 111: ENGINE_APPS="@ENGINE_BEANS@" Line 112: ENGINE_APPS="${ENGINE_APPS} @ENGINE_ROOT@" Line 113: ENGINE_APPS="${ENGINE_APPS} @ENGINE_RESTAPI@" Line 114: ENGINE_APPS="${ENGINE_APPS} @ENGINE_USERPORTAL@" Line 115: ENGINE_APPS="${ENGINE_APPS} @ENGINE_WEBADMIN@" I do not change the "commit message" text, you will be able to deploy jars/wars from wherever you want, later when the series will be actively discussed we can continue this discussion, as there will be a single one the ear for now without modification of its path. If I understand correctly, the 'wars' term is what you see problematic, so what about /usr/share/ovirt-engine/webapp/*.{jar,war} for provided artifacts? It does not mean that more applications will not be able to install their own artifacts elsewhere, but it does create sane grouping of our bundle. Line 116: Line 117: # Line 118: # Flags to enable or disable the web server (the proxy) and the Line 119: # connectors of the application server: -- To view, visit http://gerrit.ovirt.org/13796 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30abd8c33bf4e879372dc3cf43b55f24ccdcfd6d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches