Itamar Heim has posted comments on this change. Change subject: core: Add Task Manager Tables ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/dbscripts/upgrade/03_01_0160_add_job_subject_entity_table.sql Line 13: CONSTRAINT pk_jobs_subject_entity PRIMARY KEY(job_id,entity_id,entity_type) I think the main question is indeed on expected behavior (since i don't see a difference between doing events in two tables rather than in a single table with another level (i.e., STEP instead of INFO or ERROR) so question is would we want the user to be able to: - see history of job steps after the job has ended, until the job is cleared by time/manually by user - would we want to benefit from the search mechanism on these events - would we want to allow event notifications on them later - would we want to benefit from the existing mechanism of clearing up events after 30 days (I actually don't feel strongly about this - just want to make sure we think about the bigger picture and mechanisms we already have) -- To view, visit http://gerrit.ovirt.org/1083 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib662f58d8a739b1fa44f4c4ec25f053923178fc0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
