Itamar Heim has posted comments on this change. Change subject: core: Add Task Manager Tables ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/dbscripts/upgrade/03_01_0160_add_job_subject_entity_table.sql Line 13: CONSTRAINT pk_jobs_subject_entity PRIMARY KEY(job_id,entity_id,entity_type) why do you need the entity_type as part of the primary key? is there any way the same entity_id will appear more than once for same job_id with a different entity_type? also, wondering what the flow is if entity is deleted (i see cascade delete is only on job_id - but what is expected behavior if entity is deleted when there are jobs for it?) -- To view, visit http://gerrit.ovirt.org/1083 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib662f58d8a739b1fa44f4c4ec25f053923178fc0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
