Eli Mesika has posted comments on this change. Change subject: core: Add Task Manager Tables ......................................................................
Patch Set 1: (8 inline comments) .................................................... File backend/manager/dbscripts/upgrade/03_01_0150_add_job_table.sql Line 5: IF EXISTS (SELECT * FROM pg_tables WHERE tablename ILIKE 'job') THEN please use the standard information_schema.tables Line 6: RETURN; I prefer to do IF NOT EXIST instead then you do not need the return Line 18: start_time TIMESTAMP WITH TIME ZONE NOT NULL, Doesn't this should get now() as default ? .................................................... File backend/manager/dbscripts/upgrade/03_01_0160_add_job_subject_entity_table.sql Line 5: IF EXISTS (SELECT * FROM pg_tables WHERE tablename ILIKE 'job_subject_entity') THEN please use the standard nformation_schema.tables Line 6: RETURN; I prefer to do IF NOT EXIST instead then you do not need the return .................................................... File backend/manager/dbscripts/upgrade/03_01_0170_add_step_table.sql Line 5: IF EXISTS (SELECT * FROM pg_tables WHERE tablename ILIKE 'step') THEN please use information_schema.tables Line 6: RETURN; I prefer to do IF NOT EXIST instead then you do not need the return Line 19: start_time TIMESTAMP WITH TIME ZONE NOT NULL, doesn't this should have now() as default ? -- To view, visit http://gerrit.ovirt.org/1083 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib662f58d8a739b1fa44f4c4ec25f053923178fc0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
