Moti Asayag has posted comments on this change. Change subject: core: Add Task Manager Tables ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/dbscripts/upgrade/03_01_0160_add_job_subject_entity_table.sql Line 13: CONSTRAINT pk_jobs_subject_entity PRIMARY KEY(job_id,entity_id,entity_type) the tables contains only 3 fields, it seems more efficient to get the data from the index rather getting the rowid by jobid and entity id and searching the data again by the rowid for the entity type. If entity is deleted, e.g. RemoveVm, the job should describe the deletion operation. At the deletion the status of the VM should be change to ImageLocked till the removal. During that period any other command should fail in the can-do-action, which means a job in status failed with a single step for validation. If the command will fail due to missing entity, the job should be marked as failed with the proper step it failed in: validation, execution or other step created to describe it. -- To view, visit http://gerrit.ovirt.org/1083 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib662f58d8a739b1fa44f4c4ec25f053923178fc0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
