Moti Asayag has posted comments on this change. Change subject: core: Add Task Manager Tables ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/dbscripts/upgrade/03_01_0160_add_job_subject_entity_table.sql Line 13: CONSTRAINT pk_jobs_subject_entity PRIMARY KEY(job_id,entity_id,entity_type) After re-thinking i'd prefer adding description field which holds the interpreted message, same as done in the audit_log table and same as planned for the step entity instead of maintaining the material of the messages (values of the message placeholders) in the db. Same behaviour as done in the event_log in which the message is stored and presented by the UI. -- To view, visit http://gerrit.ovirt.org/1083 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib662f58d8a739b1fa44f4c4ec25f053923178fc0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
