junrushao commented on code in PR #78:
URL: https://github.com/apache/tvm-ffi/pull/78#discussion_r2404740963
##########
include/tvm/ffi/object.h:
##########
@@ -202,10 +202,7 @@ class Object {
TVMFFIObject header_;
public:
- Object() {
- header_.combined_ref_count = 0;
- header_.deleter = nullptr;
- }
+ Object() : header_{} {}
Review Comment:
Reverted back to using assign. I don't believe it's less efficient or less
readable for POD types, but don't want to be fixated about this particular
implementation detail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
