junrushao commented on code in PR #78:
URL: https://github.com/apache/tvm-ffi/pull/78#discussion_r2404746699
##########
include/tvm/ffi/function.h:
##########
@@ -315,21 +315,21 @@ class Function : public ObjectRef {
* \param packed_call The packed function signature
*/
template <typename TCallable>
- static Function FromPacked(TCallable packed_call) {
+ static Function FromPacked(TCallable&& packed_call) {
Review Comment:
Note: signature change. It's `std::forward`-ed in later use-sites, so I
suppose this change should be fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
