tqchen commented on code in PR #78:
URL: https://github.com/apache/tvm-ffi/pull/78#discussion_r2404216781
##########
include/tvm/ffi/extra/module.h:
##########
@@ -201,7 +203,7 @@ class Module : public ObjectRef {
/*!
* \brief Property of ffi::Module
*/
- enum ModulePropertyMask : int {
+ enum ModulePropertyMask : std::uint8_t {
Review Comment:
for ABI stability, we should keep it as int
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
