junrushao commented on code in PR #78:
URL: https://github.com/apache/tvm-ffi/pull/78#discussion_r2404678733
##########
src/ffi/extra/library_module_dynamic_lib.cc:
##########
@@ -45,7 +45,7 @@ namespace ffi {
class DSOLibrary final : public Library {
public:
explicit DSOLibrary(const String& name) { Load(name); }
- ~DSOLibrary() {
+ ~DSOLibrary() override {
Review Comment:
That's not necessary but it's recommended by
[modernize-use-override](https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-override.html).
For some reason, the standard practice is to always mark override/final to
prevent typos such as qualifier change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
