junrushao commented on code in PR #78:
URL: https://github.com/apache/tvm-ffi/pull/78#discussion_r2404761069


##########
include/tvm/ffi/function.h:
##########
@@ -763,7 +767,8 @@ struct TypeTraits<TypedFunction<FType>> : public 
TypeTraitsBase {
   }
 
   TVM_FFI_INLINE static void MoveToAny(TypedFunction<FType> src, TVMFFIAny* 
result) {
-    TypeTraits<Function>::MoveToAny(std::move(src.packed()), result);
+    // Move from rvalue to trigger TypedFunction rvalue packed() overload
+    TypeTraits<Function>::MoveToAny(std::move(src).packed(), result);

Review Comment:
   Seems plausible change but not entirely sure



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to