William A. Rowe, Jr. wrote:
Filip Hanik - Dev Lists wrote:
for those not following the entire non existent revolution, here is the
veto that was being debated
Thanks, I have a question below...
[EMAIL PROTECTED] wrote:
Author: fhanik
Date: Tue May 29 15:23:36 2007
New Revision: 542678
URL: http://svn.apache.org/viewvc?view=rev&rev=542678
Log:
setup default operation
Modified:
tomcat/trunk/java/org/apache/catalina/connector/CometEventImpl.java
Modified:
tomcat/trunk/java/org/apache/catalina/connector/CometEventImpl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/CometEventImpl.java?view=diff&rev=542678&r1=542677&r2=542678
==============================================================================
---
tomcat/trunk/java/org/apache/catalina/connector/CometEventImpl.java
(original)
+++
tomcat/trunk/java/org/apache/catalina/connector/CometEventImpl.java
Tue May 29 15:23:36 2007
@@ -41,6 +41,11 @@
public CometEventImpl(Request request, Response response) {
this.request = request;
this.response = response;
+ try {
+ this.register(CometOperation.OP_READ);
+ }catch ( IOException x ) {
+ throw new IllegalStateException(x.getMessage(),x);
+ }
}
To keep with the proper commit handling procedures of the ASF, I think I
have to veto all these changes, so that they are not considered as
having been accepted inside an official branch. They have to be
considered a proposal (even though the branch they live in sounds
official), but of course, no need to revert them.
Rémy
I'm confused. I see the veto, I don't see the justification in that
veto message.
There's a large thread on these issues. At the time, the API design was
downright bad. It did improve to some extent (without further debate),
but this was all done in trunk without any collaboration.
I wish to move out the current trunk and use stricter commit policies to
avoid these sort of issues, and force agreement before commit.
Rémy
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
