Filip Hanik - Dev Lists wrote: > for those not following the entire non existent revolution, here is the > veto that was being debated
Thanks, I have a question below... > [EMAIL PROTECTED] wrote: >> Author: fhanik >> Date: Tue May 29 15:23:36 2007 >> New Revision: 542678 >> >> URL: http://svn.apache.org/viewvc?view=rev&rev=542678 >> Log: >> setup default operation >> >> Modified: >> tomcat/trunk/java/org/apache/catalina/connector/CometEventImpl.java >> >> Modified: >> tomcat/trunk/java/org/apache/catalina/connector/CometEventImpl.java >> URL: >> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/CometEventImpl.java?view=diff&rev=542678&r1=542677&r2=542678 >> >> ============================================================================== >> >> --- >> tomcat/trunk/java/org/apache/catalina/connector/CometEventImpl.java >> (original) >> +++ >> tomcat/trunk/java/org/apache/catalina/connector/CometEventImpl.java >> Tue May 29 15:23:36 2007 >> @@ -41,6 +41,11 @@ >> public CometEventImpl(Request request, Response response) { >> this.request = request; >> this.response = response; >> + try { >> + this.register(CometOperation.OP_READ); >> + }catch ( IOException x ) { >> + throw new IllegalStateException(x.getMessage(),x); >> + } >> } > > To keep with the proper commit handling procedures of the ASF, I think I > have to veto all these changes, so that they are not considered as > having been accepted inside an official branch. They have to be > considered a proposal (even though the branch they live in sounds > official), but of course, no need to revert them. > > Rémy I'm confused. I see the veto, I don't see the justification in that veto message. What "proper commit handling procedures"? You don't vote first on C-T-R branches like trunk. You vote against the code you don't like with a justification of why you don't like it (and what the author can do to help you like it.) Or you vote for it just to show moral support. Then you vote up or down on a release, someday in the future, when there is an RM who wants to release it. The rules were very deliberately designed to prevent any one person from hijacking a project, either in releasing software the project isn't satisfied with, or in being an obstacle to releasing software the project is satisfied with. Bill --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
