kangpinghuang commented on a change in pull request #1633: add zone map
page(#1390)
URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315021792
##########
File path: be/src/olap/rowset/segment_v2/column_writer.h
##########
@@ -128,11 +131,15 @@ class ColumnWriter {
Status _write_data_page(Page* page);
Status _write_physical_page(std::vector<Slice>* origin_data, PagePointer*
pp);
+ void _reset_page_zone_map();
+
private:
ColumnWriterOptions _opts;
const TypeInfo* _type_info = nullptr;
bool _is_nullable;
WritableFile* _output_file = nullptr;
+ WrapperField* _page_min_value = nullptr;
+ WrapperField* _page_max_value = nullptr;
Review comment:
ok, I will move them to Builder and add two apis to set them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
