kangpinghuang commented on a change in pull request #1633: add zone map
page(#1390)
URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315079568
##########
File path: be/src/olap/rowset/segment_v2/ordinal_page_index.h
##########
@@ -55,9 +56,11 @@ class OrdinalPageIndexBuilder {
_num_pages++;
}
- Slice finish() {
- // encoded number of elements
+ Slice finish(rowid_t row_num) {
+ // encoded number of pages
encode_fixed32_le((uint8_t*)_buffer.data(), _num_pages);
+ // encoded number of rows
+ encode_fixed32_le((uint8_t*)_buffer.data() + 4, row_num);
Review comment:
OK, I will use SegmentFooterPB.num_rows and pass it through constructor
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
