kangpinghuang commented on a change in pull request #1633: add zone map
page(#1390)
URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315100961
##########
File path: be/src/olap/rowset/segment_v2/column_writer.cpp
##########
@@ -139,8 +153,19 @@ Status ColumnWriter::_append_data(const uint8_t** ptr,
size_t num_rows) {
_null_bitmap_builder->add_run(false, num_written);
}
- // TODO(zc): update statistics for this page
-
+ if (_opts.need_zone_map) {
+ for (int i = 0; i < num_written; ++i) {
+ if (!_page_min_value->is_null()
+ &&
_page_min_value->field()->compare(_page_min_value->cell_ptr(), start_ptr) > 0) {
+ _page_min_value->copy(start_ptr);
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
