gortiz commented on code in PR #14479:
URL: https://github.com/apache/pinot/pull/14479#discussion_r1856756045


##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/IndexingConfig.java:
##########
@@ -410,6 +411,14 @@ public void setSegmentNameGeneratorType(String 
segmentNameGeneratorType) {
     _segmentNameGeneratorType = segmentNameGeneratorType;
   }
 
+  public boolean isIndexCapacityThresholdCheckEnabled() {
+    return _indexCapacityThresholdCheckEnabled;
+  }
+
+  public void setIndexCapacityThresholdCheckEnabled(boolean 
indexCapacityThresholdCheckEnabled) {
+    _indexCapacityThresholdCheckEnabled = indexCapacityThresholdCheckEnabled;
+  }
+

Review Comment:
   We may also want to set this for all tables. I would recommend (maybe in a 
future PR) to add an instance level configuration option to be the default 
value for this config. That way users can change the property at startup and 
that way they won't need to change hundreds of tables.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to