Jackie-Jiang commented on code in PR #14479:
URL: https://github.com/apache/pinot/pull/14479#discussion_r1848784907
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java:
##########
@@ -797,6 +801,18 @@ private void addNewRow(int docId, GenericRow row) {
recordIndexingError(indexEntry.getKey(), e);
}
}
+
+ if (_thresholdForNumOfColValuesEnabled) {
+ int prevCount = indexContainer._valuesInfo.getNumValues();
+ long newCount = prevCount + 1L + values.length;
Review Comment:
Essentially what we want to ensure is that whatever accepted in mutable
segment won't cause problem when the mutable segment is sealed.
I'm okay if we only limit total values here, but we need to enhance
immutable index so that it can hold 2B values regardless of the bit length per
value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
