Jackie-Jiang commented on code in PR #14479:
URL: https://github.com/apache/pinot/pull/14479#discussion_r1870391606
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java:
##########
@@ -828,7 +829,20 @@ private void addNewRow(int docId, GenericRow row) {
Object[] values = (Object[]) value;
for (Map.Entry<IndexType, MutableIndex> indexEntry :
indexContainer._mutableIndexes.entrySet()) {
try {
- indexEntry.getValue().add(values, dictIds, docId);
+ MutableIndex mutableIndex = indexEntry.getValue();
+ mutableIndex.add(values, dictIds, docId);
+ // Few of the Immutable version of the mutable index are bounded
by size like FixedBitMVForwardIndex.
+ // If num of values overflows or size is above limit, A mutable
index is unable to convert to
+ // an immutable index and segment build fails causing the realtime
consumption to stop.
+ // Hence, The below check is a temporary measure to avoid such
scenarios until immutable index
+ // implementations are changed.
+ if (!mutableIndex.canAddMore()) {
+ _logger.debug(
Review Comment:
Log it as info, and capitalize the first letter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
