Harnoor7 commented on code in PR #14479: URL: https://github.com/apache/pinot/pull/14479#discussion_r1849039834
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java: ########## @@ -797,6 +801,18 @@ private void addNewRow(int docId, GenericRow row) { recordIndexingError(indexEntry.getKey(), e); } } + + if (_thresholdForNumOfColValuesEnabled) { + int prevCount = indexContainer._valuesInfo.getNumValues(); + long newCount = prevCount + 1L + values.length; Review Comment: hmm. Okay, let me figure out if we can even do this on ingestion side considering we have 5 different implementations of immutable forward index for MV columns each having diff size limit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org