Harnoor7 commented on code in PR #14479:
URL: https://github.com/apache/pinot/pull/14479#discussion_r1849053682
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java:
##########
@@ -797,6 +801,18 @@ private void addNewRow(int docId, GenericRow row) {
recordIndexingError(indexEntry.getKey(), e);
}
}
+
+ if (_thresholdForNumOfColValuesEnabled) {
+ int prevCount = indexContainer._valuesInfo.getNumValues();
+ long newCount = prevCount + 1L + values.length;
Review Comment:
We can keep threshold near 500 million for numOfValues which will be good
enough for few immutable indexes but not for varByte fwd index having 4GB Limit
(2GB wasted). However this will ensure we never encounter numOfValues overflow
and index limit size reached exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
