tibrewalpratik17 commented on code in PR #14469:
URL: https://github.com/apache/pinot/pull/14469#discussion_r1847760269
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompaction/UpsertCompactionTaskGenerator.java:
##########
@@ -155,6 +159,10 @@ public List<PinotTaskConfig>
generateTasks(List<TableConfig> tableConfigs) {
SegmentSelectionResult segmentSelectionResult =
processValidDocIdsMetadata(taskConfigs, completedSegmentsMap,
validDocIdsMetadataList);
+ LOGGER.info("Selected {} segments for compaction, {} segments for
deletion and skipped {} segments for table: {}",
+ segmentSelectionResult.getSegmentsForCompaction().size(),
+ segmentSelectionResult.getSegmentsForDeletion().size(),
segmentSelectionResult._skippedSegments.size(),
+ tableNameWithType);
Review Comment:
Instead of adding skippedSegments var for just this log line, we can
calculate skippedSegments size here itself using
`validDocIdsMetadataList.size() -
segmentSelectionResult.getSegmentsForCompaction().size() -
segmentSelectionResult.getSegmentsForDeletion().size()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
