dang-stripe commented on code in PR #14469:
URL: https://github.com/apache/pinot/pull/14469#discussion_r1847736159
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompaction/UpsertCompactionTaskExecutor.java:
##########
@@ -108,7 +110,11 @@ protected SegmentConversionResult convert(PinotTaskConfig
pinotTaskConfig, File
.setSegmentName(segmentName).build();
long endMillis = System.currentTimeMillis();
- LOGGER.info("Finished task: {} with configs: {}. Total time: {}ms",
taskType, configs, (endMillis - startMillis));
+ long validDocIdsCount = validDocIds.stream().count();
Review Comment:
yeah it is the same. i originally added it because i noticed we had a case
where we were compacting the same segment repeatedly, but i think it had to do
with frequent new upserts. i'll remove the extra count.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
