dang-stripe commented on code in PR #14469:
URL: https://github.com/apache/pinot/pull/14469#discussion_r1847737708
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/BaseSingleSegmentConversionExecutor.java:
##########
@@ -132,10 +131,9 @@ public SegmentConversionResult executeTask(PinotTaskConfig
pinotTaskConfig)
// Collect the task processing metrics from various single segment
executors and publish them here.
SegmentMetadataImpl segmentMetadata = new SegmentMetadataImpl(indexDir);
- Object numRecordsPurged =
segmentConversionResult.getCustomProperty(PurgeTaskExecutor.NUM_RECORDS_PURGED_KEY);
+ Integer numRecordsPurged = segmentConversionResult.getNumRecordsPurged();
if (numRecordsPurged != null) {
- reportTaskProcessingMetrics(tableNameWithType, taskType,
segmentMetadata.getTotalDocs(),
- (int) numRecordsPurged);
+ reportTaskProcessingMetrics(tableNameWithType, taskType,
segmentMetadata.getTotalDocs(), numRecordsPurged);
Review Comment:
@tibrewalpratik17 @Jackie-Jiang i re-used the existing
`RECORDS_PURGED_COUNT` metric to track invalid records since it seems like it
was meant to be somewhat generic. let me know if a dedicated metric is
preferred instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
