Jackie-Jiang commented on code in PR #14469:
URL: https://github.com/apache/pinot/pull/14469#discussion_r1847337877
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompaction/UpsertCompactionTaskGenerator.java:
##########
@@ -218,10 +218,20 @@ public static SegmentSelectionResult
processValidDocIdsMetadata(Map<String, Stri
long totalDocs = validDocIdsMetadata.getTotalDocs();
double invalidRecordPercent = ((double) totalInvalidDocs / totalDocs)
* 100;
if (totalInvalidDocs == totalDocs) {
+ LOGGER.info("Segment {} contains only invalid records, adding it to
the deletion list", segmentName);
segmentsForDeletion.add(segment.getSegmentName());
} else if (invalidRecordPercent >= invalidRecordsThresholdPercent
&& totalInvalidDocs >= invalidRecordsThresholdCount) {
+ LOGGER.info("Segment {} contains {} invalid records out of {} total
records "
+ + "(count threshold: {}, percent threshold: {}),
adding it to the compaction list",
+ segmentName, totalInvalidDocs, totalDocs,
invalidRecordsThresholdCount,
+ invalidRecordsThresholdPercent);
segmentsForCompaction.add(Pair.of(segment, totalInvalidDocs));
+ } else {
+ LOGGER.info("Segment {} contains {} invalid records out of {} total
records "
+ + "(count threshold: {}, percent threshold: {}),
skipping it for compaction",
+ segmentName, totalInvalidDocs, totalDocs,
invalidRecordsThresholdCount,
+ invalidRecordsThresholdPercent);
Review Comment:
Another way is to collect some aggregated stats and log them in the end
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompaction/UpsertCompactionTaskExecutor.java:
##########
@@ -108,7 +110,11 @@ protected SegmentConversionResult convert(PinotTaskConfig
pinotTaskConfig, File
.setSegmentName(segmentName).build();
long endMillis = System.currentTimeMillis();
- LOGGER.info("Finished task: {} with configs: {}. Total time: {}ms",
taskType, configs, (endMillis - startMillis));
+ long validDocIdsCount = validDocIds.stream().count();
Review Comment:
Wouldn't this always be the same as `totalDocsAfterCompaction`?
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompaction/UpsertCompactionTaskExecutor.java:
##########
@@ -108,7 +110,11 @@ protected SegmentConversionResult convert(PinotTaskConfig
pinotTaskConfig, File
.setSegmentName(segmentName).build();
long endMillis = System.currentTimeMillis();
- LOGGER.info("Finished task: {} with configs: {}. Total time: {}ms",
taskType, configs, (endMillis - startMillis));
+ long validDocIdsCount = validDocIds.stream().count();
Review Comment:
Use `validDocIds.getCardinality()` instead. It is much cheaper than looping
it over.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
