tibrewalpratik17 commented on code in PR #14469:
URL: https://github.com/apache/pinot/pull/14469#discussion_r1847314371
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompaction/UpsertCompactionTaskExecutor.java:
##########
@@ -108,7 +110,11 @@ protected SegmentConversionResult convert(PinotTaskConfig
pinotTaskConfig, File
.setSegmentName(segmentName).build();
long endMillis = System.currentTimeMillis();
- LOGGER.info("Finished task: {} with configs: {}. Total time: {}ms",
taskType, configs, (endMillis - startMillis));
+ long validDocIdsCount = validDocIds.stream().count();
+ LOGGER.info("Finished task: {} with configs: {}. Total time: {}ms. "
+ + "Total docs before compaction: {}. Total docs after compaction:
{}. Valid doc IDs count: {}",
+ taskType, configs, (endMillis - startMillis),
segmentMetadata.getTotalDocs(), totalDocsAfterCompaction,
+ validDocIdsCount);
Review Comment:
Thanks for this! I was planning to add a metric to track number of rows
compacted. This was to show business impact of compaction process. If it's not
much, can you do that here itself? Thanks!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
