Jackie-Jiang commented on code in PR #14199: URL: https://github.com/apache/pinot/pull/14199#discussion_r1805628251
########## pinot-broker/src/main/java/org/apache/pinot/broker/routing/BrokerRoutingManager.java: ########## @@ -747,6 +763,7 @@ private static class RoutingEntry { _partitionMetadataManager = partitionMetadataManager; _queryTimeoutMs = queryTimeoutMs; _segmentZkMetadataFetcher = segmentZkMetadataFetcher; + _disabled = getIdealState(idealStatePath).isEnabled(); Review Comment: Don't read IS again here. In `buildRouting()`, we already read IS -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org