Jackie-Jiang commented on code in PR #14199:
URL: https://github.com/apache/pinot/pull/14199#discussion_r1805633342
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -660,7 +661,22 @@ protected BrokerResponse handleRequest(long requestId,
String query, SqlNodeAndO
List<ProcessingException> exceptions = new ArrayList<>();
if (numUnavailableSegments > 0) {
String errorMessage;
- if (numUnavailableSegments >
MAX_UNAVAILABLE_SEGMENTS_TO_PRINT_IN_QUERY_EXCEPTION) {
+ if (((realtimeTableConfig != null && offlineTableConfig != null)
Review Comment:
Say real-time table is disable, and 3 segments are unavailable in offline
table, we want to log them both. Currently it will be logged only as `offline
table disabled` but not with the unavailable segments.
In order to achieve that, we should check whether the table is disabled in
line 624 and 641, and track its unavailable segments only when it is enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
