ashishjayamohan commented on code in PR #14199:
URL: https://github.com/apache/pinot/pull/14199#discussion_r1805705497


##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -660,7 +661,22 @@ protected BrokerResponse handleRequest(long requestId, 
String query, SqlNodeAndO
       List<ProcessingException> exceptions = new ArrayList<>();
       if (numUnavailableSegments > 0) {
         String errorMessage;
-        if (numUnavailableSegments > 
MAX_UNAVAILABLE_SEGMENTS_TO_PRINT_IN_QUERY_EXCEPTION) {
+        if (((realtimeTableConfig != null && offlineTableConfig != null)

Review Comment:
   Got it, that makes sense. I had to move this check inside the if statements 
referenced at 624 and 641 because adding this extra condition interfered with 
other behavior. I've gone ahead and made those changes to the PR to have this 
intended behavior. Let me know if that looks good!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to