gortiz commented on code in PR #13956:
URL: https://github.com/apache/pinot/pull/13956#discussion_r1792205677
##########
pinot-connectors/pinot-spark-2-connector/pom.xml:
##########
@@ -35,6 +35,45 @@
</properties>
<profiles>
+ <profile>
+ <id>build-shaded-jar</id>
+ <activation>
+ <activeByDefault>true</activeByDefault>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <relocations>
+ <relocation>
+ <pattern>com</pattern>
+ <shadedPattern>${shadeBase}.com</shadedPattern>
+ <includes>
+ <include>com.google.protobuf.**</include>
+ <include>com.google.common.**</include>
+ </includes>
+ </relocation>
+ </relocations>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
+ <profile>
+ <id>pinot-fastdev</id>
Review Comment:
What we can do then is to disable these projects when pinot-fastdev is
enabled.
Basically we usually do not need to compile these projects and what we don't
want is to slow down the developer cycle just to shade a project that is not
needed to develop a normal Pinot feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
