gortiz commented on code in PR #13956:
URL: https://github.com/apache/pinot/pull/13956#discussion_r1792016528
##########
pom.xml:
##########
@@ -293,6 +293,7 @@
<!-- This plugin slows down the builds, most likely caused by an issue
in the deprecated org.apache.maven.shared.utils.io.DirectoryScanner -->
<rat.skip>true</rat.skip>
<spotless.check.skip>true</spotless.check.skip>
+ <shade.phase.prop>none</shade.phase.prop>
Review Comment:
I don't get it. `shade.phase.prop` is read in the declaration of the shade
plugin in the root pom.xml. By default this property is false in pom.xml but
override in some places:
1. In `pinot-fastdev`, to set it to false again.
2. In several subproject pom.xml, where it is set to true by default. I
tried to change that (to only enable it when some profile is enabled) but in
order to do that we would need to modify some CI scripts.
3. In these projects, in in `pinot-fastdev` we set it to false again.
I've tried to remove the 3rd use, but I guess the property defined in the
pom.xml has more priority than the one defined in a profile defined in the root
pom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
