gortiz commented on code in PR #13733:
URL: https://github.com/apache/pinot/pull/13733#discussion_r1752102288
##########
pinot-core/src/main/java/org/apache/pinot/core/query/request/context/utils/QueryContextConverterUtils.java:
##########
@@ -155,11 +157,26 @@ public static QueryContext getQueryContext(PinotQuery
pinotQuery) {
}
}
+ ExplainMode explainMode;
+ if (!pinotQuery.isExplain()) {
+ explainMode = ExplainMode.NONE;
+ } else if (isUsingV1(pinotQuery)) {
+ explainMode = ExplainMode.NODE;
+ } else {
+ explainMode = ExplainMode.DESCRIPTION;
+ }
+
return new
QueryContext.Builder().setTableName(tableName).setSubquery(subquery)
.setSelectExpressions(selectExpressions).setDistinct(distinct).setAliasList(aliasList).setFilter(filter)
.setGroupByExpressions(groupByExpressions).setOrderByExpressions(orderByExpressions)
.setHavingFilter(havingFilter).setLimit(pinotQuery.getLimit()).setOffset(pinotQuery.getOffset())
.setQueryOptions(pinotQuery.getQueryOptions()).setExpressionOverrideHints(expressionContextOverrideHints)
- .setExplain(pinotQuery.isExplain()).build();
+ .setExplain(explainMode).build();
+ }
+
+ private static boolean isUsingV1(PinotQuery pinotQuery) {
Review Comment:
Renamed and modified to delegate on QueryOptionUtils. I'm not directly using
isUseMultistageEngine because I assume the map may be null, so we need to
verify that first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
