gortiz commented on code in PR #13733:
URL: https://github.com/apache/pinot/pull/13733#discussion_r1752011166
##########
pinot-common/src/main/proto/plan.proto:
##########
@@ -193,3 +194,29 @@ message WindowNode {
int32 upperBound = 6;
repeated Literal constants = 7;
}
+
+message ExplainNode {
+ string type = 1;
Review Comment:
I think title is a better name. Type seems to indicate that it is a unique
thing that completely identifies the operator, when in fact it may not be. I've
added some documentation which emphasizes that explain nodes should not be used
to reconstruct the operators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
