gortiz commented on code in PR #13733:
URL: https://github.com/apache/pinot/pull/13733#discussion_r1750381217


##########
pinot-common/src/main/java/org/apache/pinot/common/utils/DatabaseUtils.java:
##########
@@ -32,6 +32,10 @@ public class DatabaseUtils {
   private DatabaseUtils() {
   }
 
+  public static String[] splitTableName(String tableName) {

Review Comment:
   Added the javadoc. The reason to add that is because Calcite RelBuilder 
supports qualified table names. In case we use them, this should honor them.
   
   Anyway I don't think PlanNodeToRelConverted.visitTableScan will ever be 
called given TableScans should always be transformed into other operators in 
the leaf stage.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to