gortiz commented on code in PR #13303:
URL: https://github.com/apache/pinot/pull/13303#discussion_r1738753432
##########
pinot-common/src/main/java/org/apache/pinot/common/datablock/RowDataBlock.java:
##########
@@ -58,41 +53,29 @@ protected void computeBlockObjectConstants() {
}
@Override
- protected int getDataBlockVersionType() {
- return VERSION + (Type.ROW.ordinal() << DataBlockUtils.VERSION_TYPE_SHIFT);
+ protected int getFixDataSize() {
+ return _fixDataSize;
}
@Override
protected int getOffsetInFixedBuffer(int rowId, int colId) {
return rowId * _rowSizeInBytes + _columnOffsets[colId];
}
- @Override
- protected int positionOffsetInVariableBufferAndGetLength(int rowId, int
colId) {
- int offset = getOffsetInFixedBuffer(rowId, colId);
- _variableSizeData.position(_fixedSizeData.getInt(offset));
- return _fixedSizeData.getInt(offset + 4);
- }
-
public int getRowSizeInBytes() {
return _rowSizeInBytes;
}
@Override
- public boolean equals(Object o) {
- if (this == o) {
- return true;
- }
- if (!(o instanceof RowDataBlock)) {
- return false;
- }
- RowDataBlock that = (RowDataBlock) o;
- return _rowSizeInBytes == that._rowSizeInBytes &&
Objects.deepEquals(_columnOffsets, that._columnOffsets);
+ public Type getDataBlockType() {
+ return Type.ROW;
}
+ @NotNull // the method is override just to override its nullability
annotation
Review Comment:
Good catch. In fact we should be using https://checkerframework.org/
annotations*, but in order to keep consistency lets use the ones we are already
using
/* There is a history here. There are tons of nullability annotations in
Java. Checker Framework is the result of trying to make some order in the chaos
we originally had and most large _vendors_ are using that as lingua franca.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
