gortiz commented on code in PR #13303:
URL: https://github.com/apache/pinot/pull/13303#discussion_r1738742874
##########
pinot-perf/src/main/java/org/apache/pinot/perf/BenchmarkDataBlock.java:
##########
@@ -74,22 +77,26 @@ public static void main(String[] args)
.addProfiler(GCProfiler.class));
}
- @Param(value = {"INT", "LONG", "STRING", "BYTES", "BIG_DECIMAL",
"LONG_ARRAY", "STRING_ARRAY"})
+// @Param(value = {"INT", "LONG", "STRING", "BYTES", "BIG_DECIMAL",
"LONG_ARRAY", "STRING_ARRAY"})
+ @Param(value = {"INT", "LONG", "STRING", "BYTES", "LONG_ARRAY"})
DataSchema.ColumnDataType _dataType;
@Param(value = {"COLUMNAR", "ROW"})
DataBlock.Type _blockType = DataBlock.Type.COLUMNAR;
// @Param(value = {"0", "10", "90"})
int _nullPerCent = 10;
- @Param(value = {"10000", "1000000"})
- int _rows;
+ @Param(value = {"direct_small", "heap_small", "direct_large"})
+ String _version = "heap_small";
+
+// @Param(value = {"10000", "1000000"})
+ int _rows = 10000;
Review Comment:
Do you mean to remove the comment? I think it is useful to have them there
to have easy access to other common configurations. The current configuration
(always use 10k rows and only `{"INT", "LONG", "STRING", "BYTES",
"LONG_ARRAY"}` types is useful, but keeping the larger list of params and the
other rows may be also useful in more extensive tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
